[tor-bugs] #3963 [Tor Relay]: '--service install' does not prevent Tor from running normally

[Tor Bug Tracker & Wiki]

#3963: '--service install' does not prevent Tor from running normally
-----------------------+----------------------------------------------------
 Reporter:  rransom    |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  minor      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Looks like a bug in nt_service_parse_options().  I am guessing that for
 some (all, I think) of the cases in the block starting with
 {{{
   if ((argc >= 3) &&
       (!strcmp(argv[1], "-service") || !strcmp(argv[1], "--service"))) {
 }}}
 we want to ensure that *should_exit is set to 1 before we return.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3963#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online