[tor-bugs] #3886 [Tor Directory Authority]: testingtornetwork with all new relays, none get hsdir flag

[Tor Bug Tracker & Wiki]

#3886: testingtornetwork with all new relays, none get hsdir flag
-------------------------------------+--------------------------------------
 Reporter:  arma                     |          Owner:     
     Type:  defect                   |         Status:  new
 Priority:  normal                   |      Milestone:     
Component:  Tor Directory Authority  |        Version:     
 Keywords:                           |         Parent:     
   Points:                           |   Actualpoints:     
-------------------------------------+--------------------------------------
 If you set TestingTorNetwork to 1, it sets MinUptimeHidServDirectoryV2 to
 0. So far so good.

 But then in dirserv_thinks_router_is_hs_dir() we check
 {{{
   return (router->wants_to_be_hs_dir && router->dir_port &&
           uptime > get_options()->MinUptimeHidServDirectoryV2 &&
           router->is_running);
 }}}

 Should that middle '>' be a '>=' ?

 We want to give relays with 0 uptime the hsdir flag in testing tor
 networks.

 (Leaving milestone unchosen -- should this go in 0.2.3, or into 0.2.2 on
 the theory that it's still in 'soft' stable status?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3886>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online