[tor-bugs] #4353 [Tor Client]: Tor clients without geoip DB log that they are configured to collect stats

[Tor Bug Tracker & Wiki]

#4353: Tor clients without geoip DB log that they are configured to collect stats
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 this is confusing, and might provoke some "OMG I AM A CLIENT WHAT KIND OF
 STATS ARE YOU COLLECTING" arguments (two people on #tor asked about this
 and one on the blog, now I know how they learned about stats stuff).

 probably a patch like this:

 {{{

 diff --git a/src/or/config.c b/src/or/config.c
 index ca4e71c..01d4036 100644
 --- a/src/or/config.c
 +++ b/src/or/config.c
 @@ -1410,8 +1410,9 @@ options_act(or_options_t *old_options)
      tor_free(actual_fname);
    }

 -  if (options->CellStatistics || options->DirReqStatistics ||
 -      options->EntryStatistics || options->ExitPortStatistics) {
 +  if (server_mode(options) &&
 +      (options->CellStatistics || options->DirReqStatistics ||
 +       options->EntryStatistics || options->ExitPortStatistics)) {
      time_t now = time(NULL);
      int print_notice = 0;
      if ((!old_options || !old_options->CellStatistics) &&
 }}}

 or something would fix it, but I need to look closer at it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4353>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online