[tor-bugs] #4299 [Tor Relay]: Duplicate call to connection_mark_for_close at command.c:1068 (first at command.c:1002)

[Tor Bug Tracker & Wiki]

#4299: Duplicate call to connection_mark_for_close at command.c:1068 (first at
command.c:1002)
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Hm. So the first time, the connection got marked with the (protocol)
 warning while processing a CERT cell:
       ERR("Problem setting or checking peer id"); [line 1002]

 Because apparently connection_or_client_learned_peer_id() didn't like what
 it saw.  And then at that point, we went and processed an auth_challenge
 cell anyway, and rejected it by saying the (protocol) warning:
     ERR("We haven't gotten a CERTS cell yet"); [line 1068]

 because we hadn't actually decided that we had a CERTS cell that we liked.

 One workaround here could be to just discard all cells on a marked OR
 connection.  That does feel like a fairly big change, though.  THoughts?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4299#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online