[tor-bugs] #4312 [Tor Relay]: Rate limit renegotiations

[Tor Bug Tracker & Wiki]

#4312: Rate limit renegotiations
-----------------------+----------------------------------------------------
 Reporter:  asn        |          Owner:              
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  Tor Relay  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by asn):

 wrt the bufferevents case, it seems like connection_or_handle_event_cb()
 handles renegotiation appropriately and no changes need to be made. It
 also uses tor_tls_read() and tor_tls_write() normally, so excess renegs.
 are blocked.

 If I had to make a change in connection_or_handle_event_cb() I would add a
 `tor_assert(tls->got_renegotiate)` in the body of:

 {{{if (handshakes == 2) {}}}

 But it's probably needlessly aggressive and I don't feel I know
 connection_or_handle_event_cb() well enough.

 I tested the both cases (bufferevents and no-bufferevents) in a privnet.
 they seem to work.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4312#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online