[tor-bugs] #4296 [Tor Client]: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()

Mon Oct 24 20:32:57 UTC 2011

#4296: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:              
     Type:  defect      |         Status:  needs_review
 Priority:  normal      |      Milestone:              
Component:  Tor Client  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------

Comment(by asn):

 In 859b279a5cf25, I tried to replicate the behavior of the Unix
 log_from_pipe() function which fclose()s the stream on error.

 I think in the future log_from_{pipe,handle} should raise a flag on error
 and let the caller close the stream as they like.

 I'm not feeling familiar enough with the port forwarder spawning code to
 do this modification myself.

 I documented the reference stealing behavior in f5a0813a, pull away!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4296#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online