[tor-bugs] #4296 [Tor Client]: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()

[Tor Bug Tracker & Wiki]

#4296: Trivial issues in tor_spawn_background()/tor_check_port_forwarding()
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:     
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor Client  |        Version:     
 Keywords:              |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
 Some things I noticed while coding #3472 stuff:

 * In tor_spawn_background():
 {{{
   retval = pipe(stderr_pipe);
   if (-1 == retval) {
 }}}
 if pipe() fails, the file descriptors of `pipe(stdout_pipe)` above are
 never closed.

 * In the tor_check_port_forwarding() code or in the Windows version of
 tor_read_all_handle() the stdout/stderr handles are not CloseHandle()d on
 stream error.

 I'll prepare a patch.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4296>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online