[tor-bugs] #3472 [Tor Bridge]: Implementing the pluggable-transport spec (managed proxies)

[Tor Bug Tracker & Wiki]

#3472: Implementing the pluggable-transport spec (managed proxies)
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:  asn               
     Type:  task        |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:  #3591             
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  assigned => needs_review


Comment:

 I think it's ready.

 Check out branch `bug3472_act2`.

 Some pointers:

  * I did not unify configure_proxy() and log_from_handle(). I'm hesitant
 on touching tor_read_all_handle() and making sure that nothing breaks on
 the tor_check_port_forwarding() side.
  * I tried to avoid poking into the guts of process_handle_t, but I
 couldn't avoid it when I wanted to access the stdout handle/pipe. The
 correct solution to this (and to the above) is to fix tor_read_all_handle
 and tor_read_all_from_process_stdout().
  * I ended up copying the whole tor environment to the managed proxy when
 on Windows. For some reason, libevent wouldn't create an event_base with
 the minimal TOR_PT_*/HOME/PATH environment on Windows. I didn't want to
 mess with libevent too much, and copying the whole environment is not too
 messy/bad so I left it like this.

 Steven if you could take a peek at my changes (especially the changes on
 util.[ch] and launch_managed_proxy() in transports.c) it would be great.

 Putting this in needs_review.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3472#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online