[tor-bugs] #4283 [Tor Client]: crypto_pk_cmp_keys does not document its error behaviour

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Fri Oct 21 16:21:24 UTC 2011


#4283: crypto_pk_cmp_keys does not document its error behaviour
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:     
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor Client  |        Version:     
 Keywords:              |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
 {{{
 /** Compare the public-key components of a and b.  Return -1 if a\<b, 0
  * if a==b, and 1 if a\>b.
  */
 }}}

 {{{
   if (!a || !b)
     return -1;

   if (!a->key || !b->key)
     return -1;
 }}}

 Can we replace these with asserts on 0.2.3.x?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4283>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list