[tor-bugs] #2176 [Tor bundles/installation]: Branding of TBB
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Fri Oct 21 06:07:09 UTC 2011
#2176: Branding of TBB
--------------------------------------+-------------------------------------
Reporter: ioerror | Owner: erinn
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Tor bundles/installation | Version:
Keywords: Bounty | Parent:
Points: | Actualpoints:
--------------------------------------+-------------------------------------
Comment(by ioerror):
Replying to [comment:22 mikeperry]:
> Replying to [comment:20 ioerror]:
> > I wonder if it might make sense also to have a build-deps target?
> >
> > It seems odd to me that we don't do stuff like "--disable-necko-wifi"
at build time. Why do we need WebGL and Wifi Scanning? Is this just an
oversight with this build target?
>
> We disable this stuff via about:config prefs. In general, disabling
components via multiple mechanisms just makes things harder for us later,
if/when we enable them..
Wait - what? You're kidding - right? We should not compile in this code if
we don't use it. It's not only dead code, it's vulnerable code just
waiting for a call from a ROP payload.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2176#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list