[tor-bugs] #4237 [arm]: arm warning when used with tor master

[Tor Bug Tracker & Wiki]

#4237: arm warning when used with tor master
-----------------------+----------------------------------------------------
 Reporter:  Sebastian  |          Owner:  atagar  
     Type:  defect     |         Status:  accepted
 Priority:  normal     |      Milestone:          
Component:  arm        |        Version:          
 Keywords:             |         Parent:          
   Points:             |   Actualpoints:          
-----------------------+----------------------------------------------------
Changes (by atagar):

  * status:  needs_information => accepted


Comment:

 Sebastian found the cause. New versions of tor default DirReqStatistics to
 being true, and if the geoip is unavailable then this is changed...

 {{{
 if (geoip_is_loaded()) {
   geoip_dirreq_stats_init(now);
   print_notice = 1;
 } else {
   options->DirReqStatistics = 0;
 }}}

 On reflection the issue for arm is that I'm making the assumption that tor
 uses the configurations the user gives, and if it differs then they should
 be alerted. This is the first time (that I'm aware of) that tor alters its
 own config so if you start tor with torrc X, then issue a SAVECONF right
 away, the saved torrc will functionally differ from X.

 Adding an exemption for this option to the warning.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4237#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online