[tor-bugs] #3512 [Tor Client]: Functions that perform hostname lookup should be clearly labeled

[Tor Bug Tracker & Wiki]

#3512: Functions that perform hostname lookup should  be clearly labeled
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 Grepping for the string "lookup" to see what might be problematic:

  * I should rename tor_addr_parse_reverse_lookup_name and
 tor_addr_to_reverse_lookup_name; they are too close to violating the new
 convention.
  * addr_port_lookup is a dangerous function; it '''sometimes''' does a
 lookup, but you can also use it just to parse a name if set its "addr"
 argument to NULL.  We should refactor so that everything that uses it,
 uses it for a lookup.  Stuff that uses it for simple parsing includes:
 connection_exit_begin_conn, authority_cert_parse_from_string,

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3512#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online