[tor-bugs] #4208 [Tor Weather]: Proposed fix for Weather Bug # 2719

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Oct 10 17:25:18 UTC 2011


#4208: Proposed fix for Weather Bug # 2719
-------------------------+--------------------------------------------------
 Reporter:  buzachaka    |          Owner:  kaner       
     Type:  defect       |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Tor Weather  |        Version:              
 Keywords:               |         Parent:  #2719       
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by kaner):

 Replying to [ticket:4208 buzachaka]:
 > This is a fix for the broken e-mail parser in the ctlutil.py utility of
 TOR Weather.  The original parser could not handle symbol replacement like
 ".AT." for @ and would allow illegal characters in the returned e-mail
 address.
 >
 > This fix adds two levels of address sanitation with intermediate checks
 for the existence of a valid string.  There is also a final check to make
 sure that the returned address conforms to RFC 2822.
 >
 > The repository is located at git at github.com:buzachaka/TOR-Weather.git.
 >
 > The only differences between this repository and the current master are
 in the ctlutil.py file.

 Note that next time you should add a single commit on top of the latest
 master. This makes it easier to review.

 Is the patch tested?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4208#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list