[tor-bugs] #4212 [Tor Hidden Services]: Circuit in CIRCUIT_PURPOSE_C_INTRODUCING with no rend_data

[Tor Bug Tracker & Wiki]

#4212: Circuit in CIRCUIT_PURPOSE_C_INTRODUCING with no rend_data
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  assigned          
 Priority:  major                |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------
Changes (by rransom):

  * status:  needs_review => assigned


Comment:

 Replying to [comment:4 Sebastian]:
 > The patch should return -1 instead of 0, because we're in the failure
 case here and marked circ for close.

 No.  The only caller of `rend_client_reextend_intro_circuit` whose
 behaviour is affected by its result interprets a non-zero result as
 indicating a permanent failure; this case isn't a permanent failure.
 `rend_client_reextend_intro_circuit`'s documentation comment needs to be
 changed to reflect this.

 This function's other caller only requires that it never return -2.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4212#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online