[tor-bugs] #4201 [Tor Bridge]: Bridges should not perform DNS self-tests

[Tor Bug Tracker & Wiki]

#4201: Bridges should not perform DNS self-tests
-------------------------------------+--------------------------------------
 Reporter:  rransom                  |          Owner:  warms0x           
     Type:  defect                   |         Status:  new               
 Priority:  minor                    |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Bridge               |        Version:                    
 Keywords:  easy bridge-concealment  |         Parent:                    
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------
 From `run_scheduled_events` in src/or/main.c:
 {{{
   /** 9. and if we're a server, check whether our DNS is telling stories
 to
    * us. */
   if (is_server && time_to_check_for_correct_dns < now) {
     if (!time_to_check_for_correct_dns) {
       time_to_check_for_correct_dns = now + 60 + crypto_rand_int(120);
     } else {
       dns_launch_correctness_checks();
       time_to_check_for_correct_dns = now + 12*3600 +
         crypto_rand_int(12*3600);
     }
   }
 }}}

 `is_server` in the outermost `if` statement's condition should be
 `public_server_mode(options)`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4201>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online