[tor-bugs] #3325 [Tor Client]: Log message when a client tries to connect to an invalid hostname is incorrect

[Tor Bug Tracker & Wiki]

#3325: Log message when a client tries to connect to an invalid hostname is
incorrect
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  new               
 Priority:  trivial     |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:  easy        |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by warms0x):

 * cc: warms0x (added)


Comment:

 Per my discussion in `#tor`, it would seem the appropriate course of
 action is to update `parse_extended_hostname`'s documentation. Since
 `parse_extended_hostname` actually invokes a `log_warn()` about the
 `.exit` notation being disable, it doesn't make much sense for
 `connection_ap_handshake_rewrite_and_attach` to do it as well.

 It might make sense for `parse_extended_hostname` to return a new constant
 like `DISABLED_HOSTNAME` which would prevent the `log_warn()` in the
 description

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3325#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online