[tor-bugs] #4600 [Tor Relay]: Spec doesn't mention password quotes

[Tor Bug Tracker & Wiki]

#4600: Spec doesn't mention password quotes
-----------------------+----------------------------------------------------
 Reporter:  atagar     |          Owner:     
     Type:  defect     |         Status:  new
 Priority:  trivial    |      Milestone:     
Component:  Tor Relay  |        Version:     
 Keywords:  easy       |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------

Comment(by rransom):

 Replying to [ticket:4600 atagar]:

 > I've been finding it a little frustrating to figure out when and what
 escaping is expected so I'm generally working from the assumption that I
 should ignore escaping unless specifically called out by the spec (like it
 is for authentication cookie paths, though that wasn't enough to work from
 alone [2]).

 > [2] https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/socket.py#l54

 `esc_for_log` is the only function Tor uses to escape strings sent to the
 control port.  Every quoted string Tor emits on its control port should be
 quoted (and escaped) by a call to `esc_for_log`.

 Unrelated: `getinfo_helper_listeners` is not dead code; a macro expands
 `listeners` in some ‘column’ of the list of GETINFO items (and the helpers
 that handle them) to `getinfo_helper_listeners`, and then the function
 that handles GETINFO commands calls it through a function pointer in the
 GETINFO item array.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4600#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online