[tor-bugs] #4587 [Tor Client]: Bugs in tor_tls_got_client_hello()

Mon Nov 28 20:23:09 UTC 2011

#4587: Bugs in tor_tls_got_client_hello()
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by asn):

 `0452f34e` of your `bug4587` does not rate-limit renegotiations.

 `tor_tls_finish_handshake()` does `SSL_set_info_callback(tls->ssl, NULL);`
 which doesn't get us into the `tor_tls_state_changed_callback()`.
 Before `0452f34e` we reset the callback in
 `tor_tls_set_renegotiate_callbacks()`, but now we call
 `tor_tls_set_renegotiate_callbacks()` in the very beginning and the
 callback is reset too soon.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4587#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online