[tor-bugs] #4531 [Tor Client]: connection_tls_start_handshake(): inconstistency checks of conn->tls

[Tor Bug Tracker & Wiki]

#4531: connection_tls_start_handshake(): inconstistency checks of conn->tls
------------------------+---------------------------------------------------
 Reporter:  troll_un    |          Owner:     
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor Client  |        Version:     
 Keywords:  easy        |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
 Checking for NULL from tor_tls_new() happens too late:
 {{{
   conn->tls = tor_tls_new(conn->_base.s, receiving);
   tor_tls_set_logged_address(conn->tls, // XXX client and relay?
       escaped_safe_str(conn->_base.address));
   if (!conn->tls) {
 }}}

 Before that condition tor_assert happens in the
 tor_tls_set_logged_address():
 {{{
 tor_tls_set_logged_address(tor_tls_t *tls, const char *address)
 {
   tor_assert(tls);
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4531>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online