[tor-bugs] #4519 [Tor Relay]: circuit_unlink_all_from_orconn is too expensive

[Tor Bug Tracker & Wiki]

#4519: circuit_unlink_all_from_orconn is too expensive
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  major      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 Moritz's relay spends a lot of time in circuit_unlink_all_from_orconn,
 which does a linear walk over the entire circuit list.

 To make this faster, we'll need data structures.  Currently, each
 or_connection has a doubly-linked list of its active circuits, but not of
 _all_ its circuits.  Adding such a doubly-linked-list is the obvious
 solution.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4519>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online