[tor-bugs] #4060 [EFF-HTTPS Everywhere]: Add a global enable / disable to the Toolbar Menu

[Tor Bug Tracker & Wiki]

#4060: Add a global enable / disable to the Toolbar Menu
----------------------------------+-----------------------------------------
 Reporter:  pde                   |          Owner:  pde         
     Type:  enhancement           |         Status:  needs_review
 Priority:  minor                 |      Milestone:              
Component:  EFF-HTTPS Everywhere  |        Version:              
 Keywords:                        |         Parent:              
   Points:                        |   Actualpoints:              
----------------------------------+-----------------------------------------
Changes (by pde):

 * cc: mikeperry (added)


Comment:

 Replying to [comment:6 jacobske87]:

 >
 > I feel like this is a really hackish (bad) way to do this - Is there an
 easier way to toggle the other callbacks (I'm not even seeing
 addEventListener/addObservers for them?), or just use the if/else
 statements? I'm open to suggestions.
 >

 We can use if/else if all else fails, but let's try to do it right first.

 We aren't making the addCategoryManager registration call shown here:
 https://developer.mozilla.org/En/NsIContentPolicy .  I think that's
 because XPCOMUtils is doing it for us from the _xpcom_categories attribute
 of the prototype (see
 https://developer.mozilla.org/en/JavaScript_code_modules/XPCOMUtils.jsm).

 But you could certainly try calling this guy to undo the registration that
 XPCOMUtils made for us:
 https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsICategoryManager#deleteCategoryEntry()

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4060#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online