[tor-bugs] #4060 [EFF-HTTPS Everywhere]: Add a global enable / disable to the Toolbar Menu

[Tor Bug Tracker & Wiki]

#4060: Add a global enable / disable to the Toolbar Menu
----------------------------------+-----------------------------------------
 Reporter:  pde                   |          Owner:  pde         
     Type:  enhancement           |         Status:  needs_review
 Priority:  minor                 |      Milestone:              
Component:  EFF-HTTPS Everywhere  |        Version:              
 Keywords:                        |         Parent:              
   Points:                        |   Actualpoints:              
----------------------------------+-----------------------------------------

Comment(by pde):

 So I tried to merge this with master (the results are in the global-
 enable-disable branch of [https://gitweb.torproject.org/pde/https-
 everywhere.git my remote]).  It doesn't seem to be working: I still find,
 for instance, that google.com is remapped to https://encrypted.google.com.

 I haven't looked at the code super closely but I suspect you aren't
 toggling our nsIContentPolicy->shouldLoad() callback.  You might find this
 summary of the places we hook useful:
 https://bugzilla.mozilla.org/show_bug.cgi?id=677643#c26, but note that we
 also have some callbacks when cookies are set, in order to enforce the
 <securecookie> directives in rulesets -- we should double check those too.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4060#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online