[tor-bugs] #4462 [TorBrowserButton]: TBB tries to 'restore session' if Firefox crashed last time; then it exits when I click restore; also, isn't remembering session state dangerous?

[Tor Bug Tracker & Wiki]

#4462: TBB tries to 'restore session' if Firefox crashed last time; then it exits
when I click restore; also, isn't remembering session state dangerous?
------------------------------+---------------------------------------------
 Reporter:  arma              |          Owner:  mikeperry
     Type:  defect            |         Status:  new      
 Priority:  normal            |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:                    |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------
Changes (by mikeperry):

  * owner:  erinn => mikeperry
  * component:  Tor bundles/installation => TorBrowserButton


Comment:

 Hrmm, yes, this is bad behavior. We should not be displaying this page at
 all in the default case. I think we can do this in Torbutton.. Maybe.

 Note that we should be also preventing this thing from actually saving
 anything to restore using a new Firefox API that Mozilla created for FF4,
 and that may be why it just exits when you try to restore your blank
 session.. However, there may be an odd race condition in that API or how
 we use it as well. I've noticed on like 1 restart out of 20 that there's a
 stray url still there (#4430).

 We use the filter API because we need the session store to be partially
 active to preserve features like "Undo closed tab", which don't require
 disk access.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4462#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online