[tor-bugs] #4312 [Tor Relay]: Rate limit renegotiations

[Tor Bug Tracker & Wiki]

#4312: Rate limit renegotiations
-----------------------+----------------------------------------------------
 Reporter:  asn        |          Owner:              
     Type:  defect     |         Status:  needs_review
 Priority:  normal     |      Milestone:              
Component:  Tor Relay  |        Version:              
 Keywords:             |         Parent:              
   Points:             |   Actualpoints:              
-----------------------+----------------------------------------------------

Comment(by nickm):

 So, this is tested to prevent multiple renegotiations when using either
 bufferevents or not?

 Issues:

 In the comment:
 {{{
 +    /* Call tor_tls_got_server_hello() for every SSL ServerHello we
 +       send. */
 }}}
 I think there's a mismatch between the comment and the code.  We're about
 to call got_server_hello.  But maybe we should instead be calling a
 function called got_client_hello or sending_server_hello?

 Next: the tor_assert(tls->server_handshake_count == 2); makes me nervous.
 I don't have enough confidence there to make sure it can never be
 triggered.  Can we change it to a BUG warning?


 Next: in the last patch on that branch, should tor_tls_handshake() get a
 check here, just like read and write have?

 Last: needs a changes file.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4312#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online