[tor-bugs] #3306 [Tor Relay]: crypto_rand_int() should be returning an unsigned int

Tue May 31 12:07:30 UTC 2011

#3306: crypto_rand_int() should be returning an unsigned int
-----------------------+----------------------------------------------------
 Reporter:  asn        |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by rransom):

 wanoskarnet points out that in
 `circuit_build_times_shuffle_and_store_array`, `crypto_rand_int` can
 return a negative number, thereby possibly crashing Tor, if the CBT data
 in its state file is modified.  We probably don't care about that causing
 Tor to exit, but it should assert rather than segfaulting.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3306#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online