[tor-bugs] #3302 [Pluggable transport]: obfs2 delays sending pending data

[Tor Bug Tracker & Wiki]

#3302: obfs2 delays sending pending data
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn
     Type:  defect               |         Status:  new
 Priority:  normal               |      Milestone:     
Component:  Pluggable transport  |        Version:     
 Keywords:                       |         Parent:     
   Points:                       |   Actualpoints:     
---------------------------------+------------------------------------------

Comment(by nickm):

 I really prefer the solution I outlined where obfs2_recv() can return
 something that indicates that the caller needs to do an obfs2_send() right
 away without waiting any data.

 Having the listeners have a list of connections just seems wrong, if the
 whole point is to serve as a socks_state-to-connection map.  If the
 protocol send and recv methods really truly need access to the conn_t,
 then let's just pass them the conn_t!  The functions that call proto_send
 and proto_recv have the conn_t already: no need to make the functions they
 call hunt for it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3302#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online