[tor-bugs] #3228 [Tor Bridge]: Setting BridgeRelay Triggers Assertion Failure

[Tor Bug Tracker & Wiki]

#3228: Setting BridgeRelay Triggers Assertion Failure
------------------------+---------------------------------------------------
 Reporter:  atagar      |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 A) You're still calling init_keys() later in that function for people who
 just became v3 authorities? Why twice?

 B) You probably want to check running_tor in the new location. (Note that
 you moved the clause above the "if (!running_tor) return" clause.)

 C) if options->V3AuthoritativeDir but !old_options it'll seg fault.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3228#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online