[tor-bugs] #1810 [Tor Relay]: published new server descriptor but authorities dropped because cosmetic

[Tor Bug Tracker & Wiki]

#1810: published new server descriptor but authorities dropped because cosmetic
-----------------------------------+----------------------------------------
    Reporter:  Trystero            |        Type:  defect   
      Status:  needs_review        |    Priority:  critical 
   Milestone:  Tor: 0.2.2.x-final  |   Component:  Tor Relay
     Version:                      |    Keywords:           
      Parent:                      |      Points:           
Actualpoints:                      |  
-----------------------------------+----------------------------------------

Comment(by rransom):

 Replying to [comment:6 Sebastian]:
 > The issue is that we end up calling set_onion_key() on each sighup,
 which calls mark_my_descriptor_dirty() unconditionally. This has another
 fun implication if I'm reading it right: we never actually rotate our
 onion key.

 `set_onion_key` is only called from one line in `init_keys`, and
 `init_keys` clobbers `onionkey_set_at` immediately after that call, so I
 don't think the extra calls to `set_onion_key` prevent onion key rotation.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1810#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online