[tor-bugs] #3019 [Tor Bridge]: setconf clears bridge descriptor refetch timers
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sun May 15 21:36:41 UTC 2011
#3019: setconf clears bridge descriptor refetch timers
------------------------+---------------------------------------------------
Reporter: arma | Owner: arma
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Bridge | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by arma):
Looks good to me. Thanks.
You should 'make check-spaces' it before merging.
Also, I notice the idiom
{{{
SMARTLIST_DEL_CURRENT(bridge_list, b);
tor_free(b);
}}}
and wonder if freeing b after removing it from the smartlist is ok. I
think it is. But that said, we do it the other way in dirserv.c:
{{{
tor_free(cp);
SMARTLIST_DEL_CURRENT(fps_out, cp);
}}}
Is this something we should try to develop a consistent habit around?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3019#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list