[tor-bugs] #3175 [Tor Client]: smartlist_string_num_isin's buffer is too short
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sat May 14 06:03:01 UTC 2011
#3175: smartlist_string_num_isin's buffer is too short
------------------------+---------------------------------------------------
Reporter: rransom | Owner:
Type: defect | Status: new
Priority: trivial | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version:
Keywords: easy | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
`smartlist_string_num_isin` converts an int to a 15-character or shorter
string. Its 16-byte buffer is not long enough to handle all 64-bit ints
(-2^63^ is 20 characters long, so the buffer would need to be at least 21
bytes long).
We currently only use this function for (16-bit) TCP port numbers, so this
bug doesn't actually hurt anything, but we shouldn't leave an even
slightly incorrect function lying around to bite us later.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3175>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list