[tor-bugs] #2732 [Tor Hidden Services]: Simplify hid_serv_responsible_for_desc_id

[Tor Bug Tracker & Wiki]

#2732: Simplify hid_serv_responsible_for_desc_id
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  major                |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 Replying to [comment:10 nickm]:
 > So based on all that discussion, what is the *right* behavior here?
 Should we just always accept a hidden service descriptor regardless, or
 should we add some sloppiness to the existing range test... or should we
 just add some comments here and remove the is_hs_dir test from
 hid_serv_acting_as_directory ?

 We should remove the `is_hs_dir` test from `hid_serv_acting_as_directory`
 (along with the related do-we-have-a-consensus test) for now.  Adding some
 sloppiness to the range test in `hid_serv_responsible_for_desc_id` would
 be a Good Thing, too, but that would be tricky to get right, and
 stabilizing the set of HSDir nodes is still necessary and would make
 loosening the range test less important.

 I don't like the idea of having all relays accept all HS descriptors --
 that would make filling relays' RAM easier without a significant benefit.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2732#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online