[tor-bugs] #3135 [Tor Client]: Tor segfaults on saveconf if it can't read its torrc file

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Thu May 12 02:20:26 UTC 2011


#3135: Tor segfaults on saveconf if it can't read its torrc file
------------------------+---------------------------------------------------
 Reporter:  atagar      |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 It's bogus; it should be "If the file can't be stat()ed".

 Really, though, we shouldn't be doing "if (file_status(x) == FN_FILE) {
 read_file() }" stuff.  There's a potential race condition between when we
 check the status and when we open it.  Instead we should just open the
 thing and see what happens.  That's another bug for another time, though.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3135#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list