[tor-bugs] #2536 [Tor Relay]: Disable outgoing token bucket and reduce token bucket refill interval

[Tor Bug Tracker & Wiki]

#2536: Disable outgoing token bucket and reduce token bucket refill interval
-------------------------+--------------------------------------------------
 Reporter:  karsten      |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by karsten):

 Replying to [comment:7 Flo]:
 > Replying to [comment:5 nickm]:
 >> I am skeptical about the "decrement the in-bucket when traffic is
 'generated internally' " approach.  It seems that it would require
 pervasive changes throughout the codebase.  I bet that the "adaptively
 decrease the read-rate until the write-limit is (almost) never reached)"
 approach would yield significantly more reliable and maintainable code.
 > Is it so? With my current knowledge of the code, I would suspect [...] I
 am not exactly sure [...]

 Too many uncertainties. :)  I think Nick has a point here.  We should come
 up with a patch that we're 100% sure respects the configured bandwidth
 limit, even if it doesn't give us 100% of the performance improvement that
 we hope to achieve.  We can still apply another patch that does what you
 have in mind, once that is tested more and there are fewer uncertainties.

 >> As for separating stuff: I meant separate patches, so that the features
 can be merged and reviewed independently. [...]
 > Therefore, in order to gain maximum improvements, we advise to enable
 both features. Though, technically it can be reviewed independently.

 This is only about reviewing and merging.

 > Replying to [comment:6 karsten]:
 > > Yes, Sebastian and I can help.  Where do we find the latest branch?
 >
 > Once we have agreed on a modification of the original proposal, I will
 finish and upload it to my public git-repository. At the moment there is
 the original patch available only.

 Great.  Where would we find the original patch again? :)  We can split the
 branch tomorrow and you can apply your changes to the separate branches.

 > Thanks to all of you for your help.

 Thanks for being persistent in trying to get this patch into Tor. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2536#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online