[tor-bugs] #2748 [Tor Hidden Services]: Multiple bogosities in rend_cache_lookup_v2_desc_as_dir

[Tor Bug Tracker & Wiki]

#2748: Multiple bogosities in rend_cache_lookup_v2_desc_as_dir
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  minor                |      Milestone:  Tor: 0.2.1.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by rransom):

 Replying to [comment:5 nickm]:
 > The safe_str call probably wants to be escaped_safe_str if we're
 reporting about bogus characters.

 Yes.

 > Is it possible for a hidden service directory to have a stale copy of a
 descriptor that it no longer considers itself responsible for? If so,
 removing the hid_serv_responsible_for_desc_id check is not cosmetic; it
 might make us return something we don't mean to return.

 `rend_cache_clean_v2_descs_as_dir` is called once every 30 minutes from
 `run_scheduled_events`, and discards all descriptors for which
 `hid_serv_responsible_for_desc_id` returns false.  If we care about
 getting rid of HS descriptors quickly, we should also cause
 `rend_cache_clean_v2_descs_as_dir` to be called whenever we receive a new
 consensus.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2748#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online