[tor-bugs] #2748 [Tor Hidden Services]: v2 HS dirs reply incorrectly to requests for descriptors they are not responsible for

[Tor Bug Tracker & Wiki]

#2748: v2 HS dirs reply incorrectly to requests for descriptors they are not
responsible for
---------------------------------+------------------------------------------
 Reporter:  rransom              |          Owner:  rransom           
     Type:  defect               |         Status:  needs_review      
 Priority:  minor                |      Milestone:  Tor: 0.2.1.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------

Comment(by Sebastian):

 Hrm. The documentation for rend_cache_lookup_v2_desc_as_dir() says that
 the function returns 0 if we couldn't look up the descriptor but the
 descriptor request was well-formed, so your patch violates the
 documentation here. The caller also relies on this behaviour, see comments
 in directory_handle_command_get(). Also, reading the spec, I don't see why
 a 400 response would be the right thing to send back if alice doesn't have
 the descriptor but the request was ok. Please clarify?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2748#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online