[tor-bugs] #2511 [Tor Bridge]: Tor will use an unconfigured bridge if it was a configured bridge last time you ran Tor

[Tor Bug Tracker & Wiki]

#2511: Tor will use an unconfigured bridge if it was a configured bridge last time
you ran Tor
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 The simple way of saying "do not use this descriptor" is to annotate it
 somehow on our side, e.g. in its purpose field or by making a new
 is_invalid bit. But the problem there is that when we try to add it when
 it's already in our various descriptor_maps, we need special logic to
 recognize that it's there-but-annotated and it needs to become there-but-
 annotated-differently. This logic has proved hard to figure out in #1776.

 I agree that we should make a better overall way of handling descriptors.
 But I don't think we want to try to force that into Tor 0.2.2.x. And I
 think we *do* want to get this patch into 0.2.2.x, or one of our main
 development directions for SponsorF will get derailed.

 In that new light, is this patch adequate for 0.2.2, and we can still plan
 to do some grand redesign later?

 I just pushed a bug2511 branch that patches your two issues above.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2511#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online