[tor-bugs] #2716 [Tor Directory Authority]: When we conclude a relay is unreachable, we give it free uptime

[Tor Bug Tracker & Wiki]

#2716: When we conclude a relay is unreachable, we give it free uptime
-------------------------------------+--------------------------------------
 Reporter:  arma                     |          Owner:     
     Type:  defect                   |         Status:  new
 Priority:  normal                   |      Milestone:     
Component:  Tor Directory Authority  |        Version:     
 Keywords:                           |         Parent:     
   Points:                           |   Actualpoints:     
-------------------------------------+--------------------------------------

Comment(by arma):

 Replying to [ticket:2716 arma]:
 > Seems like we should conclude you went (retroactively) down at the first
 failed test -- 16:24:04 in this case.

 A patch for that approach might look like
 {{{
 diff --git a/src/or/dirserv.c b/src/or/dirserv.c
 index aeeab45..6f81b31 100644
 --- a/src/or/dirserv.c
 +++ b/src/or/dirserv.c
 @@ -970,7 +970,8 @@ dirserv_set_router_is_running(routerinfo_t *router,
 time_t n

    if (!answer && running_long_enough_to_decide_unreachable()) {
      /* not considered reachable. tell rephist. */
 -    rep_hist_note_router_unreachable(router->cache_info.identity_digest,
 now);
 +    rep_hist_note_router_unreachable(router->cache_info.identity_digest,
 +      router->last_reachable ? router->last_reachable + 1280 : now);
    }

    router->is_running = answer;
 }}}
 except cleaned up to have 10 and 128 (both from main.c) be #defined
 constants.

 There are other calls to rep_hist_note_router_unreachable(), including the
 one we just put in for bug #1035, but they don't bother me much.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2716#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online