[tor-bugs] #2557 [BridgeDB]: BridgeDB fails with a traceback when turning off a distributor

[Tor Bug Tracker & Wiki]

#2557: BridgeDB fails with a traceback when turning off a distributor
-------------------------+--------------------------------------------------
    Reporter:  karsten   |       Owner:  nickm   
        Type:  defect    |      Status:  reopened
    Priority:  normal    |   Milestone:          
   Component:  BridgeDB  |     Version:          
  Resolution:            |    Keywords:          
      Parent:            |      Points:          
Actualpoints:            |  
-------------------------+--------------------------------------------------

Comment(by kaner):

 Replying to [comment:6 karsten]:

 > And that's what I don't understand.  Your change to the tests in 48527ea
 looks correct to me.  So, maybe there's something wrong in the
 implementation?  Also note that there's another test right after adding a
 bridge to `ring99` that needs to be changed.

 Ok. Sorry. I should have checked your initial comment about "how does it
 end up in ring1 and not in unallocated" better. Of course the bridge ends
 up in `ring1`, because it initially gets assigned to `ring1` by the first
 call to `insertBridgeAndGetRing`. Its the *same* bridge that goes in.
 Bridges aren't moved between rings. Only the time stamp gets updated the
 second time it goes in. So it was correct from the beginning on. Same goes
 for the bridge that wants to go into `ring99` btw. Same key, same ring.
 All `ring1`.

 Feel free to revert part of the last commit or simply use
 971f8aee61a03eefde45ffd319eff646e6e8252e.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2557#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online