[tor-bugs] #2678 [BridgeDB]: bridgedb /16 filtering needs review

[Tor Bug Tracker & Wiki]

#2678: bridgedb /16 filtering needs review
-------------------------+--------------------------------------------------
 Reporter:  karsten      |          Owner:     
     Type:  enhancement  |         Status:  new
 Priority:  normal       |      Milestone:     
Component:  BridgeDB     |        Version:     
 Keywords:               |         Parent:     
   Points:               |   Actualpoints:     
-------------------------+--------------------------------------------------
Changes (by karsten):

 * cc: nickm, aagbsn, kaner (added)


Comment:

 A few comments:

  - Do we want to enforce that we only return one bridge in the same /16
 for all current distributors, that is, https, email, and file buckets?
 aagbsn says yes for the former 2, but is unsure regarding the latter
 (buckets).  kaner, what's your opinion here?

  - aagbsn's patch removes bridges from the results that are in the same
 /16 as other bridges, but it doesn't add new bridges to the result.
  Shouldn't we try to return the requested number of bridges?  aagbsn is
 concerned about making it easier for people to mine BridgeDB, whereas I'm
 concerned that people won't understand why they only get 2 bridges when
 they usually get 3.

  - Should we avoid removing bridges in the same /16 if that would mean we
 cannot return the requested number of bridges (say, we have 3 bridges in a
 ring with two being in the same /16; should we return just 2 bridges or
 all 3)?  aagbsn thinks we should return just 2 bridges.  I would like to
 hear nickm's opinion here.

  - The new unit tests contain IP addresses starting with `123.321.` which
 are obviously not valid.  The unit tests still succeed, but we should
 change the addresses to something valid.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2678#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online