[tor-bugs] #2618 [Metrics]: Consolidate-stats needs update
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Mon Mar 7 15:27:19 UTC 2011
#2618: Consolidate-stats needs update
----------------------------------------------------------------------------------------------------+
Reporter: mikeperry | Owner: mikeperry
Type: defect | Status: needs_review
Priority: major | Milestone:
Component: Metrics | Version:
Keywords: TorPerfIterationFires20110305 TorPerfIteration20110305 MikePerryIterationFires20110305 | Parent:
Points: 3 | Actualpoints: 3
----------------------------------------------------------------------------------------------------+
Comment(by karsten):
Replying to [comment:11 mikeperry]:
> karsten and tomb: Ok, this is all done and test in mikeperry/ticket2618.
That branch also contains my extra_stats.py fix from mikeperry/fixfields,
so you only need to do one merge now.
>
> Note that the script behavior has changed. It no longer requires a
manual sort step, and it also only outputs matched successful fetches. The
script header informs people to keep the original .data and .extradata for
failure statistics analysis.
When you say sorting isn't necessary, what do you mean by that? I tried
the script with modified `.data` and `.extradata` files that had non-
sorted entries. The script failed for me. Or do you mean that the files
are already sorted by Torperf?
Also, I think there's a bug in this script: Whenever we skip a line in a
.data file, because that line represents a failure, we might get out of
sync with the .extradata file and stop writing any data to .mergedata.
You should be able to reproduce this bug with the Torperf 50KB run
([https://metrics.torproject.org/data/torperf-50kb.data .data],
[https://metrics.torproject.org/data/torperf-50kb.extradata .extradata]).
The last line in the result has `CIRC_ID=4384`. If I delete the line in
`.extradata` starting with `CIRC_ID=4397`, the result has more entries
than before. I think the fix is to distinguish between absolute slack of
up to 1 second and a time difference of, say, more than 1 minute.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2618#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list