[tor-bugs] #2652 [Tor Relay]: Clean up use of SSL_*_app_data functions

[Tor Bug Tracker & Wiki]

#2652: Clean up use of SSL_*_app_data functions
-----------------------+----------------------------------------------------
 Reporter:  rransom    |          Owner:  rransom           
     Type:  defect     |         Status:  new               
 Priority:  major      |      Milestone:  Tor: 0.2.3.1-alpha
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 [https://gitweb.torproject.org/tor.git/commitdiff/49de5431d53b4515d48a0f1c76fc53f3306f5d11
 Commit 49de5431d53b] made Tor use `SSL_set_app_data` and
 `SSL_get_app_data` instead of its previous hash table to look up the
 `tor_tls_t *` object corresponding to an `SSL *` object.  Unfortunately:

 * The patch left in two hash-table helper functions that it made unused.
 Reported by mobmix.
 * The patch did not check the result of `SSL_set_app_data` for errors.
 Reported by piebeer.
 * The `SSL_*_app_data` functions are actually macros wrapping
 corresponding `SSL_*_ex_data` functions in such a way that a program that
 tries to use the `app_data` and `ex_data` functions at the same time will
 break horribly.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2652>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online