[tor-bugs] #3264 [Tor Client]: Merge TLS debug branch

[Tor Bug Tracker & Wiki]

#3264: Merge TLS debug branch
-------------------------+--------------------------------------------------
 Reporter:  ioerror      |          Owner:  arma              
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 Replying to [comment:8 arma]:
 > Replying to [comment:7 nickm]:
 > > > So to be clear, these debug messages are on-by-default with no way
 to not see them. Is that ok? The original ticket suggested a config option
 which is off-by-default.
 > >
 > > There is a way not to see them: Don't enable debug-level handshake-
 domain messages.  If you are only logging at info, you're fine.  I think
 that the original ticket had been written without realizing that log
 domains already did everything we need here.
 >
 > But if you log at debug, you get them and there's no way to not get them
 (except through a complex non-standard log line where you ask for every
 domain but handshake)?

 "Nonstandard" how?  Logging at debug is already nonstandard.

 Just say "Log [~handshake]debug file /var/log/debug.log" if you don't want
 these.

 > How many debug lines are we talking about here, for a fast relay?

 We're looking at maybe 10-20 lines per connection.  Probably small in
 comparison to the "flushed %d bytes, %d ready to flush, %d remain" and
 "Read %ld bytes. %d on inbuf" messages.

 > I think the original ticket wanted to see them at log-level debug if the
 config option was on, and not at all if the config option was off. He
 wasn't hoping to see them at notice if the config option was on.

 Sure, but we aren't bound by the original ticket.  We're allowed to
 implement stuff using the infrastructure we already have, rather than
 proliferating ways to enable/disable sets of log messages.

 > The goal is to avoid making it impractical to run your relay at log-
 level debug.

 I think we meet that goal.  If not, let's scrap this and just build #3116.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3264#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online