[tor-bugs] #2580 [Torctl]: TorCtl crashes when connected to the ORPort

[Tor Bug Tracker & Wiki]

#2580: TorCtl crashes when connected to the ORPort
--------------------+-------------------------------------------------------
 Reporter:  atagar  |          Owner:  mikeperry   
     Type:  defect  |         Status:  needs_review
 Priority:  minor   |      Milestone:              
Component:  Torctl  |        Version:              
 Keywords:          |         Parent:              
   Points:  1       |   Actualpoints:              
--------------------+-------------------------------------------------------

Comment(by mikeperry):

 Replying to [comment:6 atagar]:
 > Replying to [comment:5 mikeperry]:
 > > So then this solves the more specific issue of properly catching the
 exception early on when you first ask for the PROTOCOLINFO?
 >
 > This solves uncaught exceptions when querying the PROTOCOLINFO and
 closing connection.
 >
 > > Did you test this against non-exception things like socket.error? (Ex:
 attempting to connect to a closed control port?)
 >
 > Done, TorCtl.connect() to a closed port still hits the socket.error
 results in:
 > Connection refused. Is the ControlPort enabled?

 Ok, cool. I missed the outer catch block just looking at the diff. This
 looks good to merge then.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2580#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online