[tor-bugs] #3407 [Tor Client]: connection_printf_to_buf is crazypants bizarre!

[Tor Bug Tracker & Wiki]

#3407: connection_printf_to_buf is crazypants bizarre!
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:3 nickm]:
 > Hm.  At first I was going to suggest that this go into 0.2.3, but it
 looks like this is actually triggerable: just GETCONF a key that's exactly
 the right length.
 >
 > I don't think that send_control_event_impl change is right: it looks
 like that function actually _did_ ensure that its strings had a CRLF
 before sending to send_control_event_string, and that some of its callers
 rely on this feature: Look at conrol_event_general_status and the
 functions that call it.

 `send_control_event_impl` only ensures that a string ends with CRLF if it
 is given a 10061-character-or-longer string.

 `control_event_general_status` calls `control_event_status`, which ensures
 that the format string given to `send_control_event_impl` ends with a
 CRLF.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3407#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online