[tor-bugs] #3403 [Tor Client]: Double mark-for-close when connection_ap_handshake_rewrite_and_attach rejects a stream

[Tor Bug Tracker & Wiki]

#3403: Double mark-for-close when connection_ap_handshake_rewrite_and_attach
rejects a stream
--------------------------+-------------------------------------------------
 Reporter:  rransom       |          Owner:  nickm             
     Type:  defect        |         Status:  new               
 Priority:  minor         |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client    |        Version:                    
 Keywords:  bufferevents  |         Parent:                    
   Points:                |   Actualpoints:                    
--------------------------+-------------------------------------------------
 When I attempted to connect to `http://duskgytldkxiuqc$.onion/` (using
 `usewithtor w3m`; I don't know whether Firefox would try to connect to
 that hostname) using my
 [https://gitweb.torproject.org/rransom/tor.git/shortlog/refs/heads/feature2553-v2
 feature2553-v2] branch ( `git://git.torproject.org/rransom/tor.git
 feature2553-v2` ) (compiled with `--enable-bufferevents`), Tor produced
 the following warning message:

 {{{
 Jun 15 02:41:53.000 [warn] Invalid onion hostname [scrubbed]; rejecting
 Jun 15 02:41:53.000 [warn] Bug: Duplicate call to
 connection_mark_for_close at connection.c:2956 (first at
 connection_edge.c:1702)
 }}}

 `connection.c:2956` is in `connection_handle_read_cb`;
 `connection_edge.c:1702` is in
 `connection_ap_handshake_rewrite_and_attach`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3403>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online