[tor-bugs] #3204 [Pluggable transport]: The cli interface of obfsproxy is terrible and makes children cry.

[Tor Bug Tracker & Wiki]

#3204: The cli interface of obfsproxy is terrible and makes children cry.
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:              
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by nickm):

 Reviewing...

 In 1d3d01d5b22e:

 It's spelled "SEPARATOR", not "SEPERATOR".  Sorry; English orthography is
 stupid.

 is_supported_protocol is weirdly described.  The documentation needlessly
 explains how it's implemented ("Run through all the supported protocols")
 but not what it actually does (return true if name is the name of a
 protocol and false otherwise).

 Maxing out at MAXPROTOCOLS is silly.  C has realloc for a reason.

 Please imagine doing tech support on "We don't support crappy protocols,
 son".

 What's with making temporary copies of argv when we could just have
 indices into it?

 Reviewing 67a106ad3bbafe83f1917d8060a1c78bf6d43ff6:

 Having the listener_new functions do the argument parsing is a big
 abstraction layer violation, and makes everything hard to test.  Instead,
 it's better to have the CLI code generate a listener configuration object,
 and pass that to the listener_new function.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3204#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online