[tor-bugs] #3318 [Tor Client]: Incorrect log message in token_check_object

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Fri Jun 3 03:27:15 UTC 2011


#3318: Incorrect log message in token_check_object
---------------------------+------------------------------------------------
    Reporter:  rransom     |       Owner:                    
        Type:  defect      |      Status:  needs_review      
    Priority:  trivial     |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:                    
  Resolution:              |    Keywords:  easy              
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by rransom):

 Replying to [comment:3 nickm]:
 > Well, if we really care that not all 128-byte keys will really have 1024
 bits of modulus, then fixing the log message alone isn't enough: we should
 fix the check too.

 I care about ''never'' lying to the user.  We can't check the key size in
 bits because OpenSSL's documentation says it can generate keys shorter
 than 1024 bits when it is told to generate a 1024-bit key.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3318#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list