[tor-bugs] #1035 [Tor Directory Authority]: Relay on dynamic IP marked as stable and guard

[Tor Bug Tracker & Wiki]

#1035: Relay on dynamic IP marked as stable and guard
----------------------------------------+-----------------------------------
    Reporter:  rudis                    |       Owner:  Sebastian       
        Type:  defect                   |      Status:  reopened        
    Priority:  minor                    |   Milestone:  Tor: unspecified
   Component:  Tor Directory Authority  |     Version:  0.2.0.35        
  Resolution:                           |    Keywords:                  
      Parent:                           |      Points:                  
Actualpoints:                           |  
----------------------------------------+-----------------------------------

Comment(by arma):

 Oh hey, this bug is still open. I have a bug with what we committed a few
 months back (9b64227ffd38e9):

 {{{
 Jul 07 14:08:27.000 [info] rep_hist_note_router_reachable(): Router
 BFA1BA13CAC96F8C13689FE1FDC65359ED6AC6D7 still seems Running, but its
 address appears to have changed since the last time it was reachable.  I'm
 going to treat it as having been down for 7200 seconds
 }}}

 When moria1 restarts, it says this to every relay that it finds reachable.
 Presumably that's because
 {{{
   addr_changed = at_addr &&
     tor_addr_compare(at_addr, &hist->last_reached_addr, CMP_EXACT) != 0;
   port_changed = at_port && at_port != hist->last_reached_port;
 }}}
 and last_reached_foo starts out empty.

 Perhaps we want to only say addr or port changed if they changed from
 something non-empty?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1035#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online