[tor-bugs] #2381 [Tor Relay]: Stack blowout in 0.2.3.0-alpha-dev

[Tor Bug Tracker & Wiki]

#2381: Stack blowout in 0.2.3.0-alpha-dev
-----------------------+----------------------------------------------------
 Reporter:  iang       |       Owner:                    
     Type:  defect     |      Status:  new               
 Priority:  normal     |   Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |     Version:  Tor: unspecified  
 Keywords:             |      Parent:                    
-----------------------+----------------------------------------------------

Comment(by cypherpunks):

 {{{
     switch (connection_connect(TO_CONN(conn), conn->_base.address, &addr,
                                dir_port, &socket_error)) {
       case -1:
         connection_dir_request_failed(conn); /* retry if we want */
         /* XXX we only pass 'conn' above, not 'resource', 'payload',
          * etc. So in many situations it can't retry! -RD */
         connection_free(TO_CONN(conn));
         return;
 }}}
 Loop. Recurs calls. Actually it's shouldn't even retry (if no such bug),
 it's just count the failures. I could be wrong, but
 connection_dir_request_failed(conn) here is not a good way for 0.2.1.x and
 0.2.2.x too.

 {{{
 static download_status_t consensus_dl_status[N_CONSENSUS_FLAVORS];
 }}}
 it's only DL_SCHED_GENERIC instead of DL_SCHED_CONSENSUS. Not a reason for
 bug however.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2381#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online