[tor-bugs] #2317 [Tor Client]: Missing sanity checks for cbtnummodes consensus parameter

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Wed Jan 12 21:00:02 UTC 2011


#2317: Missing sanity checks for cbtnummodes consensus parameter
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
          "CircuitPriorityHalflifeMsec" -- the halflife parameter used when
          weighting which circuit will send the next cell. Obeyed by Tor
          0.2.2.10-alpha and later.  (Versions of Tor between 0.2.2.7-alpha
          and 0.2.2.10-alpha recognized a "CircPriorityHalflifeMsec"
 parameter,
          but mishandled it badly.)
 +        Min: -1, Max: 2147483647 (INT32_MAX) XXX are these sane?
 }}}

 Currently we use < 0 to declare that we're not using it, with -1 being the
 suggested value of < 0. But what if we want to use -2 later to mean
 something else? The current clients would continue ignoring the feature,
 but new clients would have new behavior.

 I'm not saying I know we'll want to do that, but why constrain ourselves?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2317#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list